Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/elasticsearch] Initialize Component #6827

Merged
merged 12 commits into from
Dec 17, 2021
Merged

[receiver/elasticsearch] Initialize Component #6827

merged 12 commits into from
Dec 17, 2021

Conversation

BinaryFissionGames
Copy link
Contributor

Description:
Implements the interfaces for a new Elasticsearch metrics scraper.

Testing:
Unit tests for config verification & initial factory code.

Documentation:
Added README describing the component, it's configuration, and usage.

djaglowski
djaglowski reviewed Dec 16, 2021
View reviewed changes
.github/CODEOWNERS Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/README.md Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/config.go Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/config.go Outdated Show resolved Hide resolved
receiver/elasticsearchreceiver/go.mod Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member

Please address the lint error: Generated code is out of date, please run "make generate" and commit the changes in this PR.

@BinaryFissionGames
Copy link
Contributor Author

Please address the lint error: Generated code is out of date, please run "make generate" and commit the changes in this PR.

Something I want to call out about this error; running make generate was not the solution, make goporto was what I ran and gave me the diff that CI is complaining about.

@djaglowski
Copy link
Member

Something I want to call out about this error; running make generate was not the solution, make goporto was what I ran and gave me the diff that CI is complaining about.

That's good to know. Would you mind opening an issue so we can get this fixed?

@BinaryFissionGames
Copy link
Contributor Author

Looks like there already was one, #6498

@djaglowski djaglowski marked this pull request as ready for review December 16, 2021 20:09
@djaglowski djaglowski requested a review from a team as a code owner December 16, 2021 20:09
@djaglowski djaglowski added the ready to merge Code review completed; ready to merge by maintainers label Dec 16, 2021
@jpkrohling jpkrohling merged commit bfb272c into open-telemetry:main Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpkrohling jpkrohling jpkrohling approved these changes

@djaglowski djaglowski djaglowski approved these changes

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

Assignees

@owais owais

Labels
ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BinaryFissionGames @djaglowski @jpkrohling @owais