[exporter/datadogexporter] Retry per network call #6412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tings into account
Merged
1 task
a4c6d66
to
2366398
Compare
This comment has been minimized.
This comment has been minimized.
jpkrohling
reviewed
Dec 1, 2021
| @@ -156,7 +156,8 @@ func createMetricsExporter( | |||
| pushMetricsFn, | |||
| // explicitly disable since we rely on http.Client timeout logic. | |||
| exporterhelper.WithTimeout(exporterhelper.TimeoutSettings{Timeout: 0 * time.Second}), | |||
| exporterhelper.WithRetry(cfg.RetrySettings), | |||
There was a problem hiding this comment.
This looks like a breaking change. Could you add this to the changelog? Make sure also to add this to the readme. Is there a way to determine whether the retry settings were customized by users, and warn them?
There was a problem hiding this comment.
Retry settings will still be used here
ConsumeMetrics function (so, we disable the exporterhelper retry mechanism). I believe this change should be transparent to users and it will probably align closer with what one would expect from the retry settings.
jpkrohling
approved these changes
Dec 1, 2021
codeboten
approved these changes
Dec 2, 2021
jamesmoessis
pushed a commit
to atlassian-forks/opentelemetry-collector-contrib
that referenced
this pull request
Dec 8, 2021
* [exporter/datadogexporter] Refactor metadata retrier to take RetrySettings into account * [exporter/datadogexporter] Do retries per network call on the metrics side * Address review comment * Fix lint
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Signed-off-by: Bogdan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Our
Push[Metric/Trace]Datasometimes do several network calls per OTLP payload.In the case of metrics these are safe to retry so we retry them per network call.
In the case of traces it's unclear when it is safe to retry so I am disabling them for now.
Link to tracking Issue: n/a
Testing: Added unit tests. Manual tests to be done are:
Documentation: Added a comment about retry settings on traces.