[datadogexporter]: Do not rely on collector to resolve envvar when possible to resolve them #6122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssible to resolve them Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
force-pushed
the
datadogexporter
branch
from
100dd58
to
0c2ccb5
Compare
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Nov 5, 2021
Proven in open-telemetry/opentelemetry-collector-contrib#6122 that this can be done in the component itself, and no need for this complicated logic. No other usage in core/contrib. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
added a commit
to bogdandrutu/opentelemetry-collector
that referenced
this pull request
Nov 5, 2021
Proven in open-telemetry/opentelemetry-collector-contrib#6122 that this can be done in the component itself, and no need for this complicated logic. No other usage in core/contrib. Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
added a commit
to open-telemetry/opentelemetry-collector
that referenced
this pull request
Nov 10, 2021
Proven in open-telemetry/opentelemetry-collector-contrib#6122 that this can be done in the component itself, and no need for this complicated logic. No other usage in core/contrib. Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bogdan Drutu [email protected]