[observiqexporter] Allow Dialer timeout to be configured #5906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryFissionGames
force-pushed
the
observiqexporter-extra-timeouts
branch
from
59281fa
to
888dc70
Compare
djaglowski
reviewed
Nov 1, 2021
BinaryFissionGames
changed the title
djaglowski
approved these changes
Nov 2, 2021
codeboten
reviewed
Nov 8, 2021
There was a problem hiding this comment.
Thanks for the contribution.
It looks like the observiqexporter component doesnt curren't have an owner in the CODEOWNERS, any chance you'd be interested in being one @BinaryFissionGames? It appears you have the most contributions to it.
|
Yeah, it's a good idea for me to be in the codeowners for observiqexporter; I'll open a separate PR for that. Thanks @codeboten ! |
BinaryFissionGames
force-pushed
the
observiqexporter-extra-timeouts
branch
from
6912739
to
7cf9ce2
Compare
codeboten
approved these changes
Nov 17, 2021
povilasv
referenced
this pull request
in coralogix/opentelemetry-collector-contrib
Dec 19, 2022
Bump go.uber.org/zap from 1.21.0 to 1.22.0 in /cmd/builder Bump go.uber.org/zap from 1.21.0 to 1.22.0 Bump go.uber.org/atomic from 1.9.0 to 1.10.0 Co-authored-by: bogdandrutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Link to tracking Issue: N/A
Testing:
Documentation: