Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to core latest PR, fix Permanent->NewPermanent change #5471

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Upgrade to core latest PR, fix Permanent->NewPermanent change #5471

merged 1 commit into from
Sep 30, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team September 28, 2021 17:02
@tigrannajaryan
Copy link
Member

Linter is not happy.

@bogdandrutu bogdandrutu force-pushed the newpermanent branch 2 times, most recently from 7102617 to 2d59fc3 Compare September 29, 2021 00:22
@bogdandrutu
Copy link
Member Author

@tigrannajaryan linter was not happy because I changed a file where there was a use of a deprecated func :D

@tigrannajaryan
Copy link
Member

A test is broken, could be due to recent changes in combineerrors or related.

@bogdandrutu bogdandrutu force-pushed the newpermanent branch 2 times, most recently from 3f07bc0 to d8c5505 Compare September 29, 2021 19:03
@codeboten
Copy link
Contributor

Fixed the test failure caused by combineerrors changes, looks like there's still failures caused by environment expansion though.

@bogdandrutu bogdandrutu force-pushed the newpermanent branch 4 times, most recently from ddc71de to 5450716 Compare September 30, 2021 01:09
@bogdandrutu bogdandrutu merged commit 1de839d into open-telemetry:main Sep 30, 2021
@bogdandrutu bogdandrutu deleted the newpermanent branch September 30, 2021 16:12
@codeboten codeboten mentioned this pull request Oct 1, 2021
Closed
luckyj5 added a commit to luckyj5/splunk-otel-collector that referenced this pull request Oct 13, 2021
@luckyj5
added journald and updated repo to be in synch with contrib repo (ope…
3464dac 
…n-telemetry/opentelemetry-collector-contrib#5471)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@alolita alolita Awaiting requested review from alolita

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9

@anuraaga anuraaga Awaiting requested review from anuraaga

@arminru arminru Awaiting requested review from arminru

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski is a code owner

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@jmacd jmacd Awaiting requested review from jmacd jmacd is a code owner

@jpkrohling jpkrohling Awaiting requested review from jpkrohling jpkrohling is a code owner

@jsuereth jsuereth Awaiting requested review from jsuereth jsuereth is a code owner

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

@mx-psi mx-psi Awaiting requested review from mx-psi mx-psi is a code owner

@owais owais Awaiting requested review from owais

@punya punya Awaiting requested review from punya

Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bogdandrutu @tigrannajaryan @codeboten