Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing a token from Splunk HEC receiver to exporter #5435

Merged
merged 1 commit into from
Nov 16, 2021
Merged

Fix passing a token from Splunk HEC receiver to exporter #5435

merged 1 commit into from
Nov 16, 2021

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Sep 24, 2021

Description:
Fix the passthrough of HEC tokens from receiver to exporter.

Link to tracking Issue:
#5427

Testing:
Unit tests

@atoulme atoulme requested review from a team and owais September 24, 2021 23:23
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 5, 2021
@bogdandrutu bogdandrutu removed the Stale label Oct 6, 2021
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 14, 2021
@bogdandrutu bogdandrutu removed the Stale label Oct 15, 2021
@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 23, 2021
@bogdandrutu bogdandrutu removed the Stale label Oct 29, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Nov 6, 2021
@atoulme atoulme force-pushed the passthrough_token branch 2 times, most recently from 89bb329 to 200786b Compare November 12, 2021 05:31
@bogdandrutu bogdandrutu removed the Stale label Nov 12, 2021
dmitryax
dmitryax approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tigrannajaryan
Copy link
Member

Please squash into 1 commit and rebase from main. It should fix the loadtests and also EasyCLA has some trouble since Friday when there are multiple commits in the PR.

@tigrannajaryan
Copy link
Member

Please squash into 1 commit and rebase from main. It should fix the loadtests and also EasyCLA has some trouble since Friday when there are multiple commits in the PR.

@atoulme please see above ^^^. I cannot merge since the build does not pass.

@atoulme atoulme force-pushed the passthrough_token branch 2 times, most recently from a85e83c to d409cd5 Compare November 16, 2021 05:43
@atoulme
Copy link
Contributor Author

atoulme commented Nov 16, 2021

@tigrannajaryan fire away!

@tigrannajaryan tigrannajaryan merged commit 87408fd into open-telemetry:main Nov 16, 2021
@atoulme atoulme deleted the passthrough_token branch November 16, 2021 22:28
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
[docs] add status header for ballast/zpages (open-telemetry#5435)
79b7835 
Fixes open-telemetry#5375
Fixes open-telemetry#5429
Fixes open-telemetry#5428
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@owais owais Awaiting requested review from owais

@rmfitzpatrick rmfitzpatrick Awaiting requested review from rmfitzpatrick

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan

Assignees

@dmitryax dmitryax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@atoulme @tigrannajaryan @dmitryax @bogdandrutu