Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punya works for Google, not (merely) for himself #5044

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Punya works for Google, not (merely) for himself #5044

merged 1 commit into from
Aug 31, 2021

Conversation

punya
Copy link
Member

@punya punya commented Aug 31, 2021

No description provided.

@punya punya requested a review from bogdandrutu August 31, 2021 19:23
@punya punya requested a review from a team as a code owner August 31, 2021 19:23
Aneurysm9
Aneurysm9 approved these changes Aug 31, 2021
View reviewed changes
Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Punya work for Google, or does Google work for Punya?

@bogdandrutu
Copy link
Member

@punya the test failed https://app.circleci.com/pipelines/github/open-telemetry/opentelemetry-collector-contrib/19072/workflows/665e766c-ab08-4f51-8a66-cde379c3797f/jobs/157708 :)))

@bogdandrutu bogdandrutu merged commit efc9088 into main Aug 31, 2021
@bogdandrutu bogdandrutu deleted the punya-patch-1 branch August 31, 2021 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

Assignees

@anuraaga anuraaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@punya @bogdandrutu @Aneurysm9 @anuraaga