Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate translator/trace/jaeger/ #4808

Merged
merged 2 commits into from
Aug 21, 2021
Merged

Migrate translator/trace/jaeger/ #4808

merged 2 commits into from
Aug 21, 2021

Conversation

Saber-W
Copy link
Member

@Saber-W Saber-W commented Aug 20, 2021 •
edited by bogdandrutu
Loading

Link to tracking Issue: open-telemetry/opentelemetry-collector#3474

Description:
This PR migrates translator/trace/jaeger/ to pkg/translator/jaeger/.

@Saber-W Saber-W requested review from a team and bogdandrutu August 20, 2021 19:06
@Saber-W Saber-W force-pushed the translator-jaeger-migration branch 2 times, most recently from f44d28d to b1ef21f Compare August 20, 2021 19:16
bogdandrutu
bogdandrutu reviewed Aug 20, 2021
View reviewed changes
pkg/Makefile Outdated Show resolved Hide resolved
@Saber-W Saber-W force-pushed the translator-jaeger-migration branch from b1ef21f to 8db297c Compare August 20, 2021 19:25
bogdandrutu
bogdandrutu reviewed Aug 20, 2021
View reviewed changes
Copy link
Member

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports from collector internal go.opentelemetry.io/collector/internal need to be change to the new package coreinternal

bogdandrutu
bogdandrutu reviewed Aug 20, 2021
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@Saber-W Saber-W force-pushed the translator-jaeger-migration branch from 8db297c to 424d337 Compare August 20, 2021 21:58
@Saber-W Saber-W force-pushed the translator-jaeger-migration branch from 424d337 to 77f986d Compare August 20, 2021 22:38
@Saber-W Saber-W force-pushed the translator-jaeger-migration branch 2 times, most recently from 01a8336 to cd035c7 Compare August 20, 2021 23:54
@Aneurysm9
Copy link
Member

make -C pkg/translator/jaeger fmt should fix the formatting issues.

@Saber-W Saber-W force-pushed the translator-jaeger-migration branch from cd035c7 to 45102f5 Compare August 21, 2021 02:02
@Aneurysm9
Copy link
Member

Check the relative path to the test data:

--- FAIL: TestInternalTracesToJaegerProtoBatchesAndBack (0.00s)
    traces_to_jaegerproto_test.go:325: 
        	Error Trace:	traces_to_jaegerproto_test.go:325
        	Error:      	Received unexpected error:
        	            	open ../../../internal/goldendataset/testdata/generated_pict_pairs_traces.txt: no such file or directory
        	Test:       	TestInternalTracesToJaegerProtoBatchesAndBack
FAIL
FAIL	github.com/open-telemetry/opentelemetry-collector-contrib/pkg/translator/jaeger	0.025s
FAIL

@Aneurysm9 Aneurysm9 merged commit 6940b91 into open-telemetry:main Aug 21, 2021
hex1848 pushed a commit to hex1848/opentelemetry-collector-contrib that referenced this pull request Jun 2, 2022
@bogdandrutu
Remove deprecated funcs in configtelemetry (open-telemetry#4808)
04374c1 
Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogdandrutu bogdandrutu bogdandrutu left review comments

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

Assignees

@jpkrohling jpkrohling

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Saber-W @Aneurysm9 @bogdandrutu @jpkrohling