Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OTLP from SFx example #466

Merged
merged 1 commit into from
Jul 16, 2020
Merged

Conversation

flands
Copy link
Contributor

@flands flands commented Jul 15, 2020

Without specifying parameters, OTLP does not work.

Description: <Describe what has changed.
Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.>

Link to tracking Issue:

Testing: < Describe what testing was performed and which tests were added.>

Documentation: < Describe the documentation added.>

Without specifying parameters, OTLP does not work.
@flands flands requested a review from a team as a code owner July 15, 2020 23:37
@project-bot project-bot bot added this to In progress in Collector Jul 15, 2020
@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #466 into master will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #466      +/-   ##
==========================================
- Coverage   85.32%   85.24%   -0.08%     
==========================================
  Files         179      179              
  Lines        9552     9552              
==========================================
- Hits         8150     8143       -7     
- Misses       1086     1089       +3     
- Partials      316      320       +4     
Flag Coverage Δ
#integration 71.09% <ø> (ø)
#unit 85.05% <ø> (-0.08%) ⬇️
Impacted Files Coverage Δ
exporter/signalfxexporter/dimensions/requests.go 84.48% <0.00%> (-8.63%) ⬇️
receiver/carbonreceiver/transport/tcp_server.go 65.71% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b09552...3110533. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Jul 16, 2020
@bogdandrutu bogdandrutu merged commit f0fc0d1 into open-telemetry:master Jul 16, 2020
Collector automation moved this from Reviewer approved to Done Jul 16, 2020
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
OpenCensus E2E test was previously using JaegerThrift sender.
Now it uses OpenCensus protocol on both ends.
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
* Move dependencies of tools package to a tools directory

* remove TOOLS_MOD_DIR from ALL_GO_MOD_DIRS in a Makefile.
then run 'go mod tidy' on ALL_GO_MOD_DIRS and TOOLS_MOD_DIR.

Co-authored-by: Rahul Patel <[email protected]>
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
* Update changelog ahead of v0.29.0 release

* Add upgrade guide to changelog
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants