Migrate opencensusexporter from Collector core to Collector contrib #4657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alolita
added
release:required-for-ga
|
Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks! |
|
@alolita these are impossible to merge, every test is failing. |
|
Hi @bogdandrutu - We're following a 3 step process for moving each of the identified components to contrib. For each component, there are two PRs:
For all components in core, NOTE: Please note in the interim tests will break. We are working to make sure all required tests pass for you to be able to merge in contrib. |
Saber-W
requested review from
alolita,
Aneurysm9,
anuraaga,
arminru,
djaglowski,
jmacd,
jpkrohling,
jrcamp,
jsuereth,
kbrockhoff,
mx-psi,
owais and
punya
as code owners
Saber-W
force-pushed
the
opencensusexporter-migration
branch
from
5cfc275
to
f34cf9b
Compare
Saber-W
force-pushed
the
opencensusexporter-migration
branch
3 times, most recently
from
b09cb69
to
f188ee8
Compare
Saber-W
force-pushed
the
opencensusexporter-migration
branch
from
f188ee8
to
ab1c866
Compare
|
@Saber-W please rebase, and replace usage of core "internaldata" with the new translator "opencensus". |
Saber-W
force-pushed
the
opencensusexporter-migration
branch
from
ab1c866
to
9594fc3
Compare
Saber-W
force-pushed
the
opencensusexporter-migration
branch
from
9594fc3
to
75d27f4
Compare
anuraaga
approved these changes
Aug 23, 2021
Aneurysm9
approved these changes
Aug 23, 2021
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
…pen-telemetry#4657) This is a preliminary change in order to support single/multiple local/remote config sources. This PR changes the Provider to accept an URI as the resource identifier. The current way is still fully supported and will continue to be supported, but there are more ways to specify the file: Command line(currently supported): `./otelcol --config=local.yaml` Command line(currently supported): `./otelcol --config=/path/to/local.yaml` Command line(new support): `./otelcol --config=file:/path/to/local.yaml` Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR migrates the opencensusexporter component from the Collector core repository to the Collector contrib repository.
This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.
Link to tracking Issue:
opentelemetry-collector/#3474
opentelemetry-collector/#3650