Migrate filterprocessor from Collector core to Collector contrib #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alolita
added
release:required-for-ga
|
Hi @bogdandrutu @tigrannajaryan based on our discussion last week, we're starting to file PRs to move each core component to contrib. Please review and merge. Thanks! |
mx-psi
previously requested changes
Aug 17, 2021
Saber-W
force-pushed
the
filterprocessor-migration
branch
2 times, most recently
from
3c59838
to
0d34751
Compare
Saber-W
force-pushed
the
filterprocessor-migration
branch
from
0d34751
to
e15ed8c
Compare
Aneurysm9
reviewed
Aug 21, 2021
Aneurysm9
approved these changes
Aug 21, 2021
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
The guidelines are necessary to explain how we want to generally approach external process execution. This was recently brought up in open-telemetry#6512 If we accept these guidelines the following should happen: - The prometheusexecreceiver should be modified to allow only a hard-coded list of exporters. - The fluentbitextension should be either removed or significantly limited in terms of what locations and what executable file names it can allow. - open-telemetry#6512 will be rejected, possibly substituted by a plugin system that @zenmoto referred to in open-telemetry#6512 (comment) if we find useful to have such plugin system.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR migrates the filterprocessor component from the Collector core repository to the Collector contrib repository.
This PR retains the commit history from core and includes plumbing fixes for go.mod, makefile, components.go.
Link to tracking Issue:
opentelemetry-collector/#3474
opentelemetry-collector/#3644