resourcedetectionprocessor: populate SchemaURL #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes ensures that all resources modified by resourcedetectionprocessor set the SchemaURL if it is not already set. The assumption is that the code that detects the resources uses semantic conventions defined in package "conventions".
tigrannajaryan
requested review from
anuraaga,
jrcamp,
mx-psi and
a team
as code owners
anuraaga
approved these changes
Aug 13, 2021
anuraaga
reviewed
Aug 13, 2021
mx-psi
approved these changes
Aug 13, 2021
| if currentSchemaURL == newSchemaURL { | ||
| return currentSchemaURL | ||
| } | ||
| // TODO: handle the case when the schema URLs are different by performing |
There was a problem hiding this comment.
Should we open an issue to track this?
There was a problem hiding this comment.
Filed an issue #4620
tigrannajaryan
deleted the
feature/tigran/resourcedetectionprocessor-schema-url
branch
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
This changes ensures that all resources modified by resourcedetectionprocessor set the SchemaURL if it is not already set. The assumption is that the code that detects the resources uses semantic conventions defined in package "conventions".
hex1848
pushed a commit
to hex1848/opentelemetry-collector-contrib
that referenced
this pull request
Jun 2, 2022
…open-telemetry#4608) * Deprecate `config.Config` and `config.Service`, use `service.Config*` Fixes open-telemetry/opentelemetry-collector#4605 Followup PRs: * Move service/internal/configunmarshaler as private struct into service/ to avoid circular dependency (no public API change) * Change service/internal/builders to private structs in service/ or don't pass config, instead only pass the components and pipeline from the config. While doing this, I realize that the "service" section in our config is a bit useless, we can think of promoting everything under "service::" one level up. Signed-off-by: Bogdan Drutu <[email protected]> * Update moved_service.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes ensures that all resources modified by resourcedetectionprocessor
set the SchemaURL if it is not already set. The assumption is that the code that
detects the resources uses semantic conventions defined in package "conventions".