signalfxexporter: update labels -> attributes #4603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
approved these changes
Aug 11, 2021
tigrannajaryan
approved these changes
Aug 12, 2021
| dimensionsValue[pos].Key = k | ||
| dimensionsValue[pos].Value = v | ||
| dimensionsValue[pos].Value = v.StringVal() |
There was a problem hiding this comment.
Bit: add a link to open-telemetry/opentelemetry-collector#3815 so that we can find it easily.
There was a problem hiding this comment.
I added it in the task list.
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
Following the changes in core to OTLP 0.9.0 to move away from `Labels` and on to `Attributes` **Link to tracking Issue:** Part of open-telemetry/opentelemetry-collector#3535
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Following the changes in core to OTLP 0.9.0 to move away from
Labelsand on toAttributesLink to tracking Issue: Part of open-telemetry/opentelemetry-collector#3535