Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SignalFx demo configuration #371

Merged
merged 6 commits into from
Jul 7, 2020
Merged

Add SignalFx demo configuration #371

merged 6 commits into from
Jul 7, 2020

Conversation

flands
Copy link
Contributor

@flands flands commented Jun 27, 2020

  • collector.yaml
  • k8s.yaml

@flands
Add SignalFx demo configuration
cd5785a 
* collector.yaml
* k8s.yaml
@flands flands requested a review from a team as a code owner June 27, 2020 02:40
@codecov
Copy link

codecov bot commented Jun 27, 2020 •
edited
Loading

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #371   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         171      171           
  Lines        9261     9261           
=======================================
  Hits         7732     7732           
  Misses       1199     1199           
  Partials      330      330
Flag Coverage Δ
#integration 63.40% <ø> (ø)
#unit 83.27% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72b1c5...87aee8d. Read the comment docs.

@tigrannajaryan tigrannajaryan added this to In progress in Collector via automation Jun 29, 2020
owais
owais reviewed Jul 6, 2020
View reviewed changes
examples/signalfx/signalfx-collector.yaml Outdated Show resolved Hide resolved
examples/signalfx/signalfx-k8s.yaml Outdated Show resolved Hide resolved
examples/signalfx/signalfx-k8s.yaml Outdated Show resolved Hide resolved
owais
owais approved these changes Jul 7, 2020
View reviewed changes
examples/signalfx/signalfx-collector.yaml Outdated
# https://github.com/signalfx/signalfx-istio-adapter
zipkin:
processors:
batch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add blank line after each component? Would help visually associate comments with components.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum is the lack of black lines so this can be pasted directly into the k8s config?

Collector automation moved this from In progress to Reviewer approved Jul 7, 2020
@tigrannajaryan
Copy link
Member

Based on guidance from TC vendor-specific examples should be placed in vendor-specific exporter/receiver directories (see e.g. splunkhexexporter).

pjanotti
pjanotti reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just small suggestions.

examples/signalfx/signalfx-collector.yaml Outdated Show resolved Hide resolved
examples/signalfx/signalfx-collector.yaml Outdated
#- key: environment
#value: "YOUR_ENVIRONMENT_NAME"
#action: insert
queued_retry:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be more readable if this one is together with batch at top

examples/signalfx/signalfx-collector.yaml Outdated
# https://github.com/signalfx/signalfx-istio-adapter
zipkin:
processors:
batch:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum is the lack of black lines so this can be pasted directly into the k8s config?

examples/signalfx/signalfx-k8s.yaml Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu merged commit 6a8ece4 into open-telemetry:master Jul 7, 2020
Collector automation moved this from Reviewer approved to Done Jul 7, 2020
@flands flands deleted the flands/sfx-demo branch July 7, 2020 17:36
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
@flands @pjanotti @wyTrivail
Add SignalFx demo configuration (#371)
1ef4814 
* Add SignalFx demo configuration

* collector.yaml
* k8s.yaml

* Update signalfx-k8s.yaml

* Enable Zipkin for Istio Mixer Adapter

* Update examples/signalfx/signalfx-collector.yaml

Co-authored-by: Paulo Janotti <[email protected]>

* Update examples/signalfx/signalfx-k8s.yaml

Co-authored-by: Paulo Janotti <[email protected]>

* Move to exporter directory

Co-authored-by: Paulo Janotti <[email protected]>
mxiamxia referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 22, 2020
@tigrannajaryan
Rename all github paths from opentelemtry-service to opentelemetry-co…
dc6b290 
…llector (#371)

This is part of renaming task: open-telemetry/opentelemetry-collector#352
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
@djaglowski
Remove restructure operator (#371)
03a140e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pjanotti pjanotti pjanotti left review comments

@owais owais owais approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

Assignees

@pmcollins pmcollins

Labels
None yet
Projects
No open projects
Collector
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@flands @tigrannajaryan @owais @bogdandrutu @pjanotti @pmcollins