Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out "not found pod ip" condition in k8s processor for metrics #361

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

dmitryax
Copy link
Member

Description:
It addresses comment #358 (comment)

@dmitryax dmitryax requested a review from a team as a code owner June 24, 2020 20:39
@project-bot project-bot bot added this to In progress in Collector Jun 24, 2020
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #361 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #361   +/-   ##
=======================================
  Coverage   83.40%   83.40%           
=======================================
  Files         171      171           
  Lines        9244     9246    +2     
=======================================
+ Hits         7710     7712    +2     
  Misses       1203     1203           
  Partials      331      331           
Flag Coverage Δ
#integration 63.40% <ø> (ø)
#unit 83.19% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
processor/k8sprocessor/processor.go 92.66% <100.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a834563...d091d5e. Read the comment docs.

Collector automation moved this from In progress to Reviewer approved Jun 24, 2020
@tigrannajaryan tigrannajaryan merged commit 618ec78 into open-telemetry:master Jun 24, 2020
Collector automation moved this from Reviewer approved to Done Jun 24, 2020
wyTrivail referenced this pull request in mxiamxia/opentelemetry-collector-contrib Jul 13, 2020
ljmsc referenced this pull request in ljmsc/opentelemetry-collector-contrib Feb 21, 2022
bogdandrutu pushed a commit that referenced this pull request May 12, 2022
Bumps [go.opentelemetry.io/collector](https://github.com/open-telemetry/opentelemetry-collector) from 0.42.0 to 0.43.1.
- [Release notes](https://github.com/open-telemetry/opentelemetry-collector/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-collector/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-collector@v0.42.0...v0.43.1)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/collector
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
codeboten pushed a commit that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Collector
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants