Fix core go import path in build type #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting of build type was broken during change to vanity import path in core. This resulted in metrics not being served on correct address due ot change in default build type. Fixes #355
Codecov Report
@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 82.78% 82.81% +0.02%
==========================================
Files 170 170
Lines 9070 9070
==========================================
+ Hits 7509 7511 +2
+ Misses 1236 1235 -1
+ Partials 325 324 -1
Continue to review full report at Codecov.
|
|
Oh I was struggling yesterday with this particular issue as well. |
dmitryax
approved these changes
Jun 24, 2020
|
@tigrannajaryan please merge |
bogdandrutu
approved these changes
Jun 25, 2020
wyTrivail
referenced
this pull request
in mxiamxia/opentelemetry-collector-contrib
Jul 13, 2020
Setting of build type was broken during change to vanity import path in core. This resulted in metrics not being served on correct address due ot change in default build type. Fixes #355
ljmsc
referenced
this pull request
in ljmsc/opentelemetry-collector-contrib
Feb 21, 2022
implement #337
bogdandrutu
pushed a commit
that referenced
this pull request
May 12, 2022
…356) Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting of build type was broken during change to vanity import path in core.
This resulted in metrics not being served on correct address due ot change in
default build type.
Fixes #355