[exporter/datadog]: Add datadog span operation name remapping config option #3444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmustin
changed the title
mx-psi
reviewed
May 21, 2021
Co-authored-by: Pablo Baeyens <[email protected]>
merge upstream
…opentelemetry-collector-contrib into add_span_operation_name_mapping merge upstream
mx-psi
reviewed
May 27, 2021
|
@mx-psi also added a bit of cleanup as we discussed around |
mx-psi
approved these changes
Jun 3, 2021
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
…option (open-telemetry#3444) * [exporter/datadog]: add span remap option * [exporter/datadog]: add documentation around span_name_remappings config option * [exporter/datadog]: spelling and linting and other assorted small joys * Update exporter/datadogexporter/translate_traces.go Co-authored-by: Pablo Baeyens <[email protected]> * [exporter/datadog]: update span remapping to use a map * [exporter/datadog]: linting span remapper * [exporter/datadog]: add config formatting * [exporter/datadog]: update span name remappings, make some details private * [exporter/datadog]: make more details of denylister private * [expoter/datadog]: also make traceconnection private Co-authored-by: Pablo Baeyens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR address discussion in #1909 , in which users generally find the converted Datadog Span Operation Name to be unhelpful, verbose, or otherwise difficult to work with. This PR adds a configuration option
span_name_remappingswhich allows a user to pass a list of strings formatted<previous_span_operation_name> <updated_span_operation_name>so that they can convert their datadog span operation name to one they'd prefer.Link to tracking Issue: #1909
Testing: Added unit tests and updated current tests
Documentation: This is documented in our example yaml configuration