[testbed]Fix incorrect sent item count in ProviderSender #34061
+69
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahsivjar
commented
Jul 12, 2024
| # Include 'user' if the change is relevant to end users. | ||
| # Include 'api' if there is a change to a library API. | ||
| # Default: '[user]' | ||
| change_logs: [user] |
There was a problem hiding this comment.
[For reviewers] I am not entirely sure if it requires a changelog OR if the changelog should be user. Based on the contributing guidelines, the change fixes a bug in the exposed API so I have added it as user. CMIIW.
There was a problem hiding this comment.
usually it wouldn't be, but since testbed is itself considered a tool the project makes available to users, we would in this case add a changelog imo.
crobert-1
approved these changes
Jul 12, 2024
atoulme
approved these changes
Jul 13, 2024
carsonip
approved these changes
Jul 13, 2024
TylerHelmuth
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes incorrect data item sent count due to stopping the load generator.
Link to tracking Issue: Fixes #34057
Testing:
Run
cd testbed/testbed/ && while go test -v -count=1 -run=TestGeneratorAndBackend ./...; do :; donefor a satisfactory duration and ensure that there are no failures.Documentation: N/A