[processor/resource][processor/attributes] Option to read client address #34048
+172
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
internal/core
processor/attributes
github-actions
bot
requested review from
boostchicken,
fatsheep9146,
rmfitzpatrick and
TylerHelmuth
dmitryax
force-pushed
the
attributes-pocessor-add-client-address
branch
from
d307b78
to
0fc9fc4
Compare
dmitryax
force-pushed
the
attributes-pocessor-add-client-address
branch
3 times, most recently
from
ef5727f
to
c06adbb
Compare
crobert-1
reviewed
Jul 12, 2024
Add an option to extract value from a client address by specifying `client.address` value in the `from_context` field.
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
dmitryax
force-pushed
the
attributes-pocessor-add-client-address
branch
from
75ae2f5
to
ab2326b
Compare
crobert-1
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have options to extract headers and auth info from the client. This change adds an option to extract client address by specifying
client.addressvalue in thefrom_contextfield.The code to extract address from the client info is taken from the k8sattributes receiver.
Fixes #34051