Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[processor/metricstransform]: Add scaling exponential histogram support #34039

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[processor/metricstransform]: Add scaling exponential histogram support #34039

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffd1e2d
Add exp hist support to metricstransform processor
wildum Jul 10, 2024
b4f54b2
add changelog entry
wildum Jul 11, 2024
b84d13c
fix lint errors
wildum Jul 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix lint errors
  • Loading branch information
@wildum
wildum committed Jul 11, 2024
commit b84d13c28cf1cb8513b98a35fe0416360b7c0273
8 changes: 4 additions & 4 deletions processor/metricstransformprocessor/metrics_testcase_builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ type expHistogramConfig struct {
exemplarValues []float64
}

func (b builder) addExpHistogramDatapoint(start, ts pcommon.Timestamp, config expHistogramConfig) builder {
func (b builder) addExpHistogramDatapoint(config expHistogramConfig) builder {
if b.metric.Type() != pmetric.MetricTypeExponentialHistogram {
panic(b.metric.Type().String())
}
Expand All @@ -149,11 +149,11 @@ func (b builder) addExpHistogramDatapoint(start, ts pcommon.Timestamp, config ex
dp.Negative().BucketCounts().FromRaw(config.negativeCount)
for ei := 0; ei < len(config.exemplarValues); ei++ {
exemplar := dp.Exemplars().AppendEmpty()
exemplar.SetTimestamp(ts)
exemplar.SetTimestamp(1)
exemplar.SetDoubleValue(config.exemplarValues[ei])
}
dp.SetStartTimestamp(start)
dp.SetTimestamp(ts)
dp.SetStartTimestamp(1)
dp.SetTimestamp(1)
return b
}

Expand Down
16 changes: 8 additions & 8 deletions processor/metricstransformprocessor/metrics_transform_processor_testcases_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1629,7 +1629,7 @@ var (
},
in: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric1").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 5,
sum: 1359,
scale: 4,
Expand All @@ -1642,7 +1642,7 @@ var (
exemplarValues: []float64{100, 300},
}).build(),
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric2").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 3,
sum: 10100.000123,
scale: 2,
Expand All @@ -1653,7 +1653,7 @@ var (
exemplarValues: []float64{100, 300},
}).build(),
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric3").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 3,
sum: 4.3678,
scale: 7,
Expand All @@ -1663,7 +1663,7 @@ var (
positiveCount: buildExpHistogramBucket(map[int]uint64{0: 1, 48: 1, 86: 1}), // 1.123, 1.456, 1.789
}).build(),
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric4").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 3,
sum: 6.00003,
scale: 20,
Expand All @@ -1675,7 +1675,7 @@ var (
},
out: []pmetric.Metric{
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric1").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 5,
sum: 1359000,
scale: 4,
Expand All @@ -1688,7 +1688,7 @@ var (
exemplarValues: []float64{100000, 300000},
}).build(),
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric2").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 3,
sum: 1010.0000123,
scale: 2,
Expand All @@ -1699,7 +1699,7 @@ var (
exemplarValues: []float64{10, 30},
}).build(),
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric3").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 3,
sum: 436780,
scale: 7,
Expand All @@ -1709,7 +1709,7 @@ var (
positiveCount: buildExpHistogramBucket(map[int]uint64{0: 1, 48: 1, 86: 1}),
}).build(),
metricBuilder(pmetric.MetricTypeExponentialHistogram, "metric4").
addExpHistogramDatapoint(1, 1, expHistogramConfig{
addExpHistogramDatapoint(expHistogramConfig{
count: 3,
sum: 252.73926368999997,
scale: 20,
Expand Down
4 changes: 2 additions & 2 deletions processor/metricstransformprocessor/operation_scale_value.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,8 +123,8 @@ func mapToIndex(value float64, scale int) int32 {
}

func scaleExemplars(exemplars pmetric.ExemplarSlice, op *internalOperation) {
for exemplars, ei := exemplars, 0; ei < exemplars.Len(); ei++ {
exemplar := exemplars.At(ei)
for e, ei := exemplars, 0; ei < e.Len(); ei++ {
exemplar := e.At(ei)
switch exemplar.ValueType() {
case pmetric.ExemplarValueTypeInt:
exemplar.SetIntValue(int64(float64(exemplar.IntValue()) * op.configOperation.Scale))
Expand Down