[chore] [exporter/elasticsearch] remove defunct config #33803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nothing has ever used this config.
songy23
approved these changes
Jun 28, 2024
carsonip
approved these changes
Jul 1, 2024
crobert-1
reviewed
Jul 3, 2024
There was a problem hiding this comment.
I'm slightly concerned that some users are using these config options and will run into errors on upgrade. I realize they don't do anything, but it may be good to add a breaking changelog just to let users know what's going on here.
I'll defer to code owners though.
|
@crobert-1 thanks, good catch. I forgot that the config validation is strict, and would error on unknown keys. I'll add a breaking change notice. |
carsonip
approved these changes
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Remove exporter/elasticsearch config fields & mentions in the README. Nothing has ever used this config.
They were added in #2324, but were not used.
If one were to add fields to all documents, then I think that should be done with a processor.
Link to tracking Issue:
N/A
Testing:
N/A
Documentation:
N/A