Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[receiver/vcenter] Fixes multiple datacenters issue #33735

Merged
merged 4 commits into from
Jul 1, 2024
Merged

[receiver/vcenter] Fixes multiple datacenters issue #33735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ff9fc75
vcenterreceiver fixes multiple datacenter bug
StefanKurek Jun 24, 2024
856c3ab
vcenterreceiver ResourcePool Object client call will not error on not…
StefanKurek Jun 25, 2024
0d07d45
update changelog
StefanKurek Jun 28, 2024
e2b7278
vcenterreceiver updates function comment
StefanKurek Jun 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
vcenterreceiver updates function comment
  • Loading branch information
@StefanKurek
StefanKurek committed Jun 28, 2024
commit e2b7278b4dac7a6e0aa575ff06d209b76771d32c
2 changes: 1 addition & 1 deletion .chloggen/vcenterreceiver_fix_multiple_datacenters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ change_type: bug_fix
component: vcenterreceiver

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Fixes errors when multiple datacenters in some of the client calls.
note: Fixes errors in some of the client calls for environments containing multiple datacenters.

# Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
issues: [33734]
Expand Down
4 changes: 2 additions & 2 deletions receiver/vcenterreceiver/scraper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ func (v *vcenterMetricScraper) scrapeAndProcessAllMetrics(ctx context.Context, e
return errs.Combine()
}

// scrapeDatacenterInventoryListObjects scrapes and store all Datacenter objects with their InventoryLists
// scrapeDatacenterInventoryListObjects scrapes and stores all Datacenter objects with their InventoryLists
func (v *vcenterMetricScraper) scrapeDatacenterInventoryListObjects(
ctx context.Context,
errs *scrapererror.ScrapeErrors,
Expand All @@ -143,7 +143,7 @@ func (v *vcenterMetricScraper) scrapeDatacenterInventoryListObjects(
return dcs
}

// scrapeResourcePoolInventoryListObjects scrapes and store all ResourcePool objects with their InventoryLists
// scrapeResourcePoolInventoryListObjects scrapes and stores all ResourcePool objects with their InventoryLists
func (v *vcenterMetricScraper) scrapeResourcePoolInventoryListObjects(
ctx context.Context,
dcs []*object.Datacenter,
Expand Down