Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore]: move aggregation logic to internal module #33669

Merged
merged 6 commits into from
Jul 2, 2024
Merged

[chore]: move aggregation logic to internal module #33669

merged 6 commits into from
Jul 2, 2024

Conversation

odubajDT
Copy link
Contributor

@odubajDT odubajDT commented Jun 20, 2024 •
edited
Loading

Description:

  • duplicated and enhanced aggregation business logic (with median function) for common usage in follow-up tickets
  • tests

Link to tracking Issue: #16224

Follow-ups:

@odubajDT odubajDT changed the title chore: move aggregation logic to internal/coreinternal chore[internal/core]: move aggregation logic to internal/coreinternal Jun 20, 2024
@odubajDT odubajDT changed the title chore[internal/core]: move aggregation logic to internal/coreinternal [internal/core]: move aggregation logic to internal/coreinternal Jun 20, 2024
This was referenced Jun 20, 2024
Open
Open
Open
@odubajDT odubajDT changed the title [internal/core]: move aggregation logic to internal/coreinternal [internal/core]: move aggregation logic to internal module Jun 21, 2024
@odubajDT odubajDT marked this pull request as ready for review June 21, 2024 08:56
@odubajDT odubajDT requested a review from a team as a code owner June 21, 2024 08:56
@odubajDT odubajDT requested a review from crobert-1 June 21, 2024 08:56
@crobert-1 crobert-1 added processor/metricstransform Metrics Transform processor processor/transform Transform processor labels Jun 21, 2024
@crobert-1
Copy link
Member

Adding processor/transform and processor/metricstransform labels as those are the intended components using or intending to be used with this functionality.

evan-bradley
evan-bradley approved these changes Jul 1, 2024
View reviewed changes
.chloggen/aggregate-move.yaml Outdated Show resolved Hide resolved
@odubajDT odubajDT changed the title [internal/core]: move aggregation logic to internal module chore: move aggregation logic to internal module Jul 2, 2024
@odubajDT odubajDT changed the title chore: move aggregation logic to internal module [chore]: move aggregation logic to internal module Jul 2, 2024
@odubajDT
chore: move aggregation logic to internal/coreinternal
da78255 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
adapt chlog
0e4c8d0 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
expose function
db37ea7 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
minor fix
3c39cf7 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
add unit tests
29ab830 
Signed-off-by: odubajDT <[email protected]>
@odubajDT
rm chlog
916d5e4 
Signed-off-by: odubajDT <[email protected]>
@evan-bradley evan-bradley merged commit e85efb3 into open-telemetry:main Jul 2, 2024
154 checks passed
@github-actions github-actions bot added this to the next release milestone Jul 2, 2024
cparkins pushed a commit to AmadeusITGroup/opentelemetry-collector-contrib that referenced this pull request Jul 11, 2024
@odubajDT @cparkins
[chore]: move aggregation logic to internal module (open-telemetry#33669
3f6a2d1 
)

**Description:** <Describe what has changed.>
- duplicated and enhanced aggregation business logic (with median
function) for common usage in follow-up tickets
- tests

**Link to tracking Issue:** open-telemetry#16224 

**Follow-ups:**
-
open-telemetry#33655
-
open-telemetry#33334
-
open-telemetry#33423

---------

Signed-off-by: odubajDT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@crobert-1 crobert-1 Awaiting requested review from crobert-1 crobert-1 is a code owner automatically assigned from open-telemetry/collector-contrib-approvers

@dmitryax dmitryax Awaiting requested review from dmitryax

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@jpkrohling jpkrohling

Labels
internal/core processor/metricstransform Metrics Transform processor processor/transform Transform processor
Projects
None yet
Milestone
next release
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@odubajDT @crobert-1 @evan-bradley @TylerHelmuth @jpkrohling