[exporter/splunk_hec] Add a new option to limit bytes sent per HTTP connection #33586
+143
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
force-pushed
the
hec_limitcontent
branch
5 times, most recently
from
42d7da0
to
94b2516
Compare
dmitryax
reviewed
Jun 18, 2024
| } | ||
|
|
||
| if hec.contentLimit != nil { | ||
| newSent := hec.eventBytesSent.Add(int64(payloadSize)) |
There was a problem hiding this comment.
We count bytes by hec client, not by connection. So, it can drain any random connection the client obtains. Let me know if I'm missing something
There was a problem hiding this comment.
the connection is reused by the HTTP client though. Can we not assume the HTTP client is using the same HTTP connection over multiple HEC worker uses?
There was a problem hiding this comment.
I don't think can, it must be a pool of connections
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
…nnections after sending max bytes
atoulme
force-pushed
the
hec_limitcontent
branch
from
94b2516
to
86badf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add a new configuration option
max_per_conn.This new option enforces that each HTTP connection is rotated after sending a number of bytes.
By default, this limit is not set.
Testing:
Unit tests
Documentation:
Added to README.md