Add new approvers, fix auto-assign to include all approvers #3327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aneurysm9
approved these changes
May 5, 2021
mx-psi
approved these changes
May 5, 2021
tigrannajaryan
approved these changes
May 5, 2021
There was a problem hiding this comment.
@Aneurysm9 @mx-psi Welcome and thank you for taking the responsibility.
I am sure you have already seen these, but it may be worth re-reading:
https://github.com/open-telemetry/opentelemetry-collector/blob/main/CONTRIBUTING.md
https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/CONTRIBUTING.md
https://github.com/open-telemetry/opentelemetry-collector-contrib#prs-and-reviews
Please do use your approver/facilitator powers to enforce the quality and rules in the PRs from other contributors.
djaglowski
approved these changes
May 5, 2021
Signed-off-by: Bogdan Drutu <[email protected]>
| github.com/open-telemetry/opentelemetry-collector-contrib/internal/stanza v0.0.0-00010101000000-000000000000 | ||
| github.com/open-telemetry/opentelemetry-log-collection v0.17.1-0.20210409145101-a881ed8b0592 | ||
| github.com/stretchr/testify v1.7.0 | ||
| go.opentelemetry.io/collector v0.25.1-0.20210503171846-9c7c862e8547 | ||
| go.opentelemetry.io/collector v0.26.0 |
There was a problem hiding this comment.
Lint failed :( I had to do it
thepeterstone
pushed a commit
to thepeterstone/opentelemetry-collector-contrib
that referenced
this pull request
May 10, 2021
…emetry#3327) Signed-off-by: Bogdan Drutu <[email protected]>
alexperez52
referenced
this pull request
in open-o11y/opentelemetry-collector-contrib
Aug 18, 2021
Change obsreport helpers for scraper to use the same pattern as Processor/Exporter and modified existences in the code. **Link to tracking Issue:** [Issue #3313](open-telemetry/opentelemetry-collector#3313)
mstumpfx
pushed a commit
to mstumpfx/opentelemetry-collector-contrib
that referenced
this pull request
Aug 31, 2021
…emetry#3327) Signed-off-by: Bogdan Drutu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @Aneurysm9 @mx-psi
Signed-off-by: Bogdan Drutu [email protected]