[exporter/sumologic]: remove deprecated configuration options #33012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aboguszewski-sumo,
kkujawa-sumo,
mat-rumian,
rnishtala-sumo and
swiatekm
sumo-drosiek
changed the title
…e unused code Signed-off-by: Dominik Rosiek <[email protected]>
sumo-drosiek
force-pushed
the
drosiek-refactor
branch
from
f4477be
to
cbc6ce9
Compare
crobert-1
reviewed
May 13, 2024
| @@ -81,6 +65,53 @@ func createDefaultClientConfig() confighttp.ClientConfig { | |||
| } | |||
| } | |||
|
|
|||
| func (cfg *Config) Validate() error { | |||
There was a problem hiding this comment.
Just a note, no changes made to Validate, it's just GitHub not showing that it's being moved in the file.
sumo-drosiek
commented
May 14, 2024
kkujawa-sumo
approved these changes
May 14, 2024
swiatekm
approved these changes
May 14, 2024
crobert-1
approved these changes
May 14, 2024
crobert-1
added
the
ready to merge
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…elemetry#33012) **Description:** remove deprecated configuration options and remove unused code Depends on open-telemetry#33011 **Link to tracking Issue:** open-telemetry#32315 **Testing:** * Unit tests **Documentation:** * Update Readme --------- Signed-off-by: Dominik Rosiek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
remove deprecated configuration options and remove unused code
Depends on #33011
Link to tracking Issue:
#32315
Testing:
Documentation: