[chore] catch if a file was generated and not added to working tree #32730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests don't pass, proving this test is effective. Once #32731 is merged, please rebase to latest main and let's see if the tests pass now. |
crobert-1
approved these changes
Apr 30, 2024
evan-bradley
approved these changes
May 2, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…pen-telemetry#32730) **Description:** This changes the check for changes for the `make generate` step. We check if any files are present that are not checked in. Co-authored-by: Evan Bradley <[email protected]> Co-authored-by: Curtis Robert <[email protected]>
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…pen-telemetry#32730) **Description:** This changes the check for changes for the `make generate` step. We check if any files are present that are not checked in. Co-authored-by: Evan Bradley <[email protected]> Co-authored-by: Curtis Robert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This changes the check for changes for the
make generatestep. We check if any files are present that are not checked in.