Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter/signalfx: Remove certain Smart Agent style metrics from exclude list #3270

Merged

Conversation

asuresh4
Copy link
Member

Description: Remove certain Smart Agent style metrics from default exclude list. The metrics that are being removed from the list in this PR are no longer generated in exporter by translation rules, so it's unnecessary to have these metrics in the default exclude list.

@asuresh4 asuresh4 requested a review from a team as a code owner April 28, 2021 17:56
@asuresh4
Copy link
Member Author

ptal @mstumpfx

Copy link

@mstumpfx mstumpfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu bogdandrutu merged commit 1e8d16e into open-telemetry:main Apr 29, 2021
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
* Added consumertest doc.go

* Added consumerhelper doc.go

* Fixed typo in consumerhelper doc.go

* Moved consumererror doc to doc.go

* Added consumer doc.go

* Added newline to end of doc.go

* Added simple doc.go

* Fixed typo in pdata doc.go

* Update CHANGELOG.md
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants