Fix issue when exclude_older_than is enabled without ordering_criteria configured
#32683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eria` configured
djaglowski
approved these changes
Apr 25, 2024
|
Thanks for the fix @newly12. Please address the lint failure and we'll get this merged |
|
@djaglowski I disabled the lint error for the topNOption so it can follow the interface as Option and the code looks more clean to me. Please let me know if that is not good enough. |
djaglowski
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fix issue when
exclude_older_thanis enabled withoutordering_criteriaconfiguredLink to tracking Issue: #32681
Testing:
Documentation: