[receiver/vcenter] Adds vApp Resource Attributes to Relevant VM Resources #32673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanKurek
force-pushed
the
fix/vcenterreceiver-vapp-attributes
branch
from
801e5e4
to
c09b115
Compare
StefanKurek
force-pushed
the
fix/vcenterreceiver-vapp-attributes
branch
from
c09b115
to
2b71603
Compare
djaglowski
approved these changes
Apr 25, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…rces (open-telemetry#32673) **Description:** <Describe what has changed.> When VMs have a vApp parent rather than a Resource Pool parent, rather than `vcenter.resource_pool.name` and `vcenter.resource_pool.inventory_path` resource attributes getting added to the VM resource, `vcenter.virtual_app.name` and `vcenter.virtual_app.inventory_path` resource attributes will be added for that VM instead. This way, VMs directly under vApps can still be human identifiable (especially if multiple VMs share the same name). These new attributes will be disabled by default and will have to be manually enabled in the config. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32557 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata.
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Jul 11, 2024
…rces (open-telemetry#32673) **Description:** <Describe what has changed.> When VMs have a vApp parent rather than a Resource Pool parent, rather than `vcenter.resource_pool.name` and `vcenter.resource_pool.inventory_path` resource attributes getting added to the VM resource, `vcenter.virtual_app.name` and `vcenter.virtual_app.inventory_path` resource attributes will be added for that VM instead. This way, VMs directly under vApps can still be human identifiable (especially if multiple VMs share the same name). These new attributes will be disabled by default and will have to be manually enabled in the config. **Link to tracking Issue:** <Issue number if applicable> open-telemetry#32557 **Testing:** <Describe what testing was performed and which tests were added.> Unit/integration tests updated and tested. Local environment tested. **Documentation:** <Describe the documentation added.> New documentation generated based on the metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When VMs have a vApp parent rather than a Resource Pool parent, rather than
vcenter.resource_pool.nameandvcenter.resource_pool.inventory_pathresource attributes getting added to the VM resource,vcenter.virtual_app.nameandvcenter.virtual_app.inventory_pathresource attributes will be added for that VM instead. This way, VMs directly under vApps can still be human identifiable (especially if multiple VMs share the same name).These new attributes will be disabled by default and will have to be manually enabled in the config.
Link to tracking Issue:
#32557
Testing:
Unit/integration tests updated and tested. Local environment tested.
Documentation:
New documentation generated based on the metadata.