Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove premature protection for Start/Stop in AWS components, trust Service to start once #3262

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Remove premature protection for Start/Stop in AWS components, trust Service to start once #3262

merged 1 commit into from
Apr 28, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu bogdandrutu requested a review from a team April 27, 2021 22:10
@bogdandrutu
Copy link
Member Author

Only very small number of components did this because that's what we did before. No need to protect against this.

/cc @mxiamxia @alolita @rakyll @anuraaga

@bogdandrutu bogdandrutu merged commit 84952e2 into open-telemetry:main Apr 28, 2021
@bogdandrutu bogdandrutu deleted the awsalready branch April 28, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuraaga anuraaga anuraaga approved these changes

@Aneurysm9 Aneurysm9 Aneurysm9 approved these changes

@mxiamxia mxiamxia mxiamxia approved these changes

@kbrockhoff kbrockhoff Awaiting requested review from kbrockhoff

Assignees

@anuraaga anuraaga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bogdandrutu @anuraaga @Aneurysm9 @mxiamxia