Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of GitHash in AWS components, planing to remove it, included in version #3256

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

bogdandrutu
Copy link
Member

Signed-off-by: Bogdan Drutu [email protected]

@bogdandrutu
Copy link
Member Author

/cc @mxiamxia @alolita @rakyll @anuraaga

@bogdandrutu
Copy link
Member Author

It is already included in the version, see open-telemetry/opentelemetry-collector#2992 and open-telemetry/opentelemetry-collector#2388

@mxiamxia
Copy link
Member

Thanks. It's fine to be removed and version is enough.

Copy link
Member

@Aneurysm9 Aneurysm9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since the version would include the same info. I'll make sure this is communicated to the team working on adding what would have been another use of it before they put up a PR.

@bogdandrutu bogdandrutu merged commit 12b0100 into open-telemetry:main Apr 27, 2021
@bogdandrutu bogdandrutu deleted the rmawshash branch April 27, 2021 22:19
alexperez52 referenced this pull request in open-o11y/opentelemetry-collector-contrib Aug 18, 2021
* remove legacy grpc receiver endpoint for GA release

* Update factory.go

Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
mstumpfx pushed a commit to mstumpfx/opentelemetry-collector-contrib that referenced this pull request Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants