[chore][receiver/sqlserver] Fix newlines when testing on Windows #32525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
approved these changes
Apr 18, 2024
codeboten
approved these changes
Apr 18, 2024
rimitchell
pushed a commit
to rimitchell/opentelemetry-collector-contrib
that referenced
this pull request
May 8, 2024
…n-telemetry#32525) Tests were failing on Windows because when the expected results were loaded from a file, the newlines were `\r\n` instead of `\n`. This replaces the unexpected characters for testing. This is a test only change, and re-enables the tests that were being skipped. Resolves open-telemetry#32519
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Tests were failing on Windows because when the expected results were loaded from a file, the newlines were
\r\ninstead of\n. This replaces the unexpected characters for testing.This is a test only change, and re-enables the tests that were being skipped.
Link to tracking Issue:
Resolves #32519