Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sumologicexporter: use Sumo Logic Extension for authentication and to obtain endpoint #32383

Merged

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Apr 15, 2024

Description:

Use Sumo Logic Extension for authentication and to obtain the endpoint. This is part of #31479 to make #32315 smaller, therefore it may have some unused code (like getSignalURL). Also OTLP format is not supported yet for neither of the formats

It also partially fixes #32375 (partially because as long as there is no a otlp support, data won't be pushed to Sumo Logic)

Link to tracking Issue: #31479

Testing:

  • unit tests
  • manual tests

Documentation:

  • ensures that Sumo Logic Extension documentation is valid

@sumo-drosiek sumo-drosiek force-pushed the drosiek-exporter-extension branch 5 times, most recently from 0f0b30e to ed6f5bf Compare April 16, 2024 09:56
@sumo-drosiek sumo-drosiek marked this pull request as ready for review April 16, 2024 09:57
@sumo-drosiek sumo-drosiek requested a review from a team as a code owner April 16, 2024 09:57
@sumo-drosiek
Copy link
Member Author

This PR adds functionality which doesn't work as is dedicated for OTLP format, but next PRs I'm going to add the following (if possible to split them):

  • traces support (otlp)
  • move logs signal from our repo
  • move metrics signal from our repo
  • another features (e.g. sticky session)

@sumo-drosiek
Copy link
Member Author

cc: @astencel-sumo @swiatekm-sumo

@sumo-drosiek sumo-drosiek force-pushed the drosiek-exporter-extension branch 2 times, most recently from 0be6bb2 to 0199fe2 Compare April 16, 2024 15:35
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nitpick.

exporter/sumologicexporter/config.go Outdated Show resolved Hide resolved
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
Signed-off-by: Dominik Rosiek <[email protected]>
@andrzej-stencel andrzej-stencel merged commit c3e750c into open-telemetry:main Apr 17, 2024
156 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 17, 2024
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
… obtain endpoint (open-telemetry#32383)

**Description:**

Use Sumo Logic Extension for authentication and to obtain the endpoint.
This is part of open-telemetry#31479 to make open-telemetry#32315 smaller, therefore it may have
some unused code (like `getSignalURL`). Also OTLP format is not
supported yet for neither of the formats

It also partially fixes open-telemetry#32375 (partially because as long as there is no
a otlp support, data won't be pushed to Sumo Logic)

**Link to tracking Issue:** open-telemetry#31479

**Testing:**

- unit tests
- manual tests

**Documentation:**

- ensures that Sumo Logic Extension documentation is valid

---------

Signed-off-by: Dominik Rosiek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sample config from sumologic extension doesn't work
4 participants