Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chore][exporter/sumologic]: add deduplicateErrors and decomposeHistograms functions #32316

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

sumo-drosiek
Copy link
Member

@sumo-drosiek sumo-drosiek commented Apr 11, 2024

Description:

Adds files from Sumo Logic Distribution for OpenTelemetry which are new in order to simplify review and make simpler to move the whole component.

This PR is made to simplify #32315

Link to tracking Issue:

#31479

Testing:

Unit Tests, also this code is use by our customers and internally. It is not used by now by the component, but will be when migration will be finished

Documentation: N/A

@sumo-drosiek
Copy link
Member Author

@astencel-sumo could you add label to skip changelog please 🙏 ?

@sumo-drosiek sumo-drosiek changed the title feat: move files from Sumo Logic repository which are new [exporter/sumologic]: move files from Sumo Logic repository which are new Apr 11, 2024
@sumo-drosiek sumo-drosiek force-pushed the drosiek-add-files branch 4 times, most recently from aba1c53 to 882eb89 Compare April 12, 2024 08:20
@sumo-drosiek sumo-drosiek marked this pull request as draft April 15, 2024 09:03
@sumo-drosiek sumo-drosiek marked this pull request as ready for review April 15, 2024 09:03
@sumo-drosiek
Copy link
Member Author

@swiatekm-sumo, @astencel-sumo Please review

@sumo-drosiek sumo-drosiek changed the title [exporter/sumologic]: move files from Sumo Logic repository which are new [exporter/sumologic]: move files which are new from Sumo Logic repository Apr 15, 2024
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly, this pull request adds code that is not used. I don't think this is the right way to split a big pull request into smaller chunks.

A pull request should only add/modify code that is used. Code that is not used is effectively dead code and should not be added unless/until it's actually used.

@sumo-drosiek
Copy link
Member Author

I disagree. There is a lot of dependencies in the code and this is the simplest way to move the code in small chunks. If I would have to use it, I would have to modify half of the code in addition to those files, which already takes over 400 lines.

As all files which do not modify old code are added in this PR, I would like to split next changes per signal, so they will be consistent and they will be marked as breaking changes.

@andrzej-stencel andrzej-stencel self-requested a review April 16, 2024 06:29
@andrzej-stencel
Copy link
Member

There was a voice from another maintainer saying that this is OK because there's the draft PR that shows the full picture, which makes sense. I'm unblocking this, sorry if I was too zealous about it.

Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To summarize, this PR introduces two new functions that can be used by the component:

  • deduplicateErrors
  • decomposeHistograms

I've reviewed this code like I would a library that delivers those functions, and the functions are 👌 .

@andrzej-stencel andrzej-stencel added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 16, 2024
@andrzej-stencel andrzej-stencel changed the title [exporter/sumologic]: move files which are new from Sumo Logic repository [chore][exporter/sumologic]: add deduplicateErrors and decomposeHistograms functions Apr 16, 2024
@andrzej-stencel andrzej-stencel merged commit 1b44bce into open-telemetry:main Apr 16, 2024
170 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/sumologic Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants