Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connector/spanmetrics] Add @Frapschen as code owner #32137

Merged
merged 2 commits into from
Apr 3, 2024
Merged

[connector/spanmetrics] Add @Frapschen as code owner #32137

merged 2 commits into from
Apr 3, 2024

Conversation

Frapschen
Copy link
Contributor

Description:
I would like to become a code owner of spanconector. my company already uses the spanconnector and I am also familiar with its code.

@Frapschen Frapschen requested a review from a team as a code owner April 3, 2024 03:16
@Frapschen Frapschen requested a review from songy23 April 3, 2024 03:16
@github-actions github-actions bot requested a review from portertech April 3, 2024 03:17
@Frapschen Frapschen added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 3, 2024
@atoulme
Copy link
Contributor

atoulme commented Apr 3, 2024

Please change metadata.yaml and .github/CODEOWNERS.

@codeboten codeboten merged commit 62f41ea into open-telemetry:main Apr 3, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Apr 3, 2024
@Frapschen Frapschen deleted the add_CODEOWNERS_to_spanconnector branch April 7, 2024 03:42
ycombinator pushed a commit to ycombinator/opentelemetry-collector-contrib that referenced this pull request Apr 9, 2024
@Frapschen @ycombinator
[connector/spanmetrics] Add @Frapschen as code owner (open-telemetry#…
fad4fde 
…32137)

I would like to become a code owner of spanconector. my company already
uses the spanconnector and I am also familiar with its code.
rimitchell pushed a commit to rimitchell/opentelemetry-collector-contrib that referenced this pull request May 8, 2024
@Frapschen @rimitchell
[connector/spanmetrics] Add @Frapschen as code owner (open-telemetry#…
da6194e 
…32137)

I would like to become a code owner of spanconector. my company already
uses the spanconnector and I am also familiar with its code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten approved these changes

@dmitryax dmitryax dmitryax approved these changes

@songy23 songy23 songy23 approved these changes

@portertech portertech Awaiting requested review from portertech

Assignees

@dashpole dashpole

Labels
connector/spanmetrics Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.98.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Frapschen @atoulme @codeboten @dmitryax @songy23 @dashpole