Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md of AWS S3 Exporter with example of setting AWS Crede… #31890

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Update README.md of AWS S3 Exporter with example of setting AWS Crede… #31890

merged 2 commits into from
Mar 29, 2024

Conversation

jek-bao-choo
Copy link
Contributor

…ntial for OpenTelemetry Collector Helm Chart

Description:

Link to tracking Issue:

Testing:

Documentation:

@jek-bao-choo
Update README.md of AWS S3 Exporter with example of setting AWS Crede…
7a5cad8 
…ntial for OpenTelemetry Collector Helm Chart
@jek-bao-choo jek-bao-choo requested review from atoulme and a team as code owners March 21, 2024 09:24
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Mar 21, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: dmitryax / name: Dmitrii Anoshin (a649dd8)
  • ✅ login: jek-bao-choo / name: Jek Bao CHOO (7a5cad8)

@github-actions github-actions bot requested a review from pdelewski March 21, 2024 09:24
@jek-bao-choo
Copy link
Contributor Author

Hi @atoulme @dmitryax would you be able to accept my PR? Thanks.

@Frapschen Frapschen added the documentation Improvements or additions to documentation label Mar 22, 2024
@Frapschen
Copy link
Contributor

@jek-bao-choo please sign CLA

@jek-bao-choo
Copy link
Contributor Author

hi @Frapschen Thank you for reaching out. It's signed.

@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 27, 2024
@dmitryax dmitryax merged commit 19da245 into open-telemetry:main Mar 29, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@MovieStoreGuy MovieStoreGuy MovieStoreGuy approved these changes

@atoulme atoulme Awaiting requested review from atoulme atoulme is a code owner

@pdelewski pdelewski Awaiting requested review from pdelewski

Assignees

@MovieStoreGuy MovieStoreGuy

Labels
documentation Improvements or additions to documentation exporter/awss3 Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.98.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jek-bao-choo @Frapschen @dmitryax @MovieStoreGuy