[receiver/sqlquery] Fix memory leak and failing tests #31785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
approved these changes
Mar 15, 2024
[receiver/sqlquery] Fix memory leak
crobert-1
force-pushed
the
sqlquery_shutdown
branch
from
468b166
to
8144a58
Compare
crobert-1
commented
Mar 15, 2024
| } | ||
| } | ||
| } | ||
| return logs, nil | ||
| return logs, errors.Join(errs...) |
There was a problem hiding this comment.
errs was originally being put together in the above loop, but not returned. I assume this was a bug and errs should be returned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes two changes that are dependent on each other.
integration_test.goare related to this.goleakstarted failing. The logs receiver opens a DB connection when it's started, but shutdown does not close the DB. This DB needs to be closed during shutdown to avoid a leaked goroutine. All changes outside ofintegration_test.goare for this.multierr.appendtoerrors.Joinas well.Link to tracking Issue:
Resolves #31782
Related to #31778
Testing:
Tests are passing