[connector/servicegraph] amend README example #31762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paschalis Tsilias <[email protected]>
jpkrohling
approved these changes
Mar 14, 2024
crobert-1
approved these changes
Mar 14, 2024
codeboten
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR amends the example configuration for the servicegraph processor to a more meaningful example
Link to tracking Issue: None filed
Testing: None
Documentation:
The type of
latency_histogram_bucketsbeing []time.Duration leads to the provided values here to be actually["1ns", "2ns", "3ns", "4ns", "5ns"]which a) is not useful, and b) is probably not what a user expects when reading this.This PR amends the example to use actual durations, so that the intent is clearer.