[chore][CONTRIBUTING.md] Add goleak to new component requirements #31689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
approved these changes
Mar 12, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…en-telemetry#31689) **Description:** The goal is for `goleak` to be required for every package, and also to be [generated by mdatagen](open-telemetry#30483). Once this is generated by `mdatagen` we'll be able to remove this from manual steps done by the user, but for now it would be good to state the it's required in docs. **Link to tracking Issue:** open-telemetry#30438
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…en-telemetry#31689) **Description:** The goal is for `goleak` to be required for every package, and also to be [generated by mdatagen](open-telemetry#30483). Once this is generated by `mdatagen` we'll be able to remove this from manual steps done by the user, but for now it would be good to state the it's required in docs. **Link to tracking Issue:** open-telemetry#30438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The goal is for
goleakto be required for every package, and also to be generated by mdatagen. Once this is generated bymdatagenwe'll be able to remove this from manual steps done by the user, but for now it would be good to state the it's required in docs.Link to tracking Issue:
#30438