Round 2: Adapt to randomly generated nop component names in unit tests #31659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
added
Skip Changelog
dashpole
requested review from
djaglowski,
a team,
atoulme and
dmitryax
as code owners
djaglowski
approved these changes
Mar 8, 2024
dmitryax
approved these changes
Mar 8, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31659 +/- ##
=======================================
Coverage 81.90% 81.91%
=======================================
Files 1853 1853
Lines 172028 172028
=======================================
+ Hits 140901 140913 +12
+ Misses 26847 26838 -9
+ Partials 4280 4277 -3 ☔ View full report in Codecov by Sentry. |
codeboten
approved these changes
Mar 11, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
open-telemetry#31659) Follow-up to open-telemetry#31640 I didn't realize the contrib test stopped after the first failure, so there were a few more failures for open-telemetry/opentelemetry-collector#9637. I verified that this passes the contrib-tests check for the core repo locally, so this should be the rest of them. For the splunkhec exporter, the exporter actually uses `ID.String()`: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/4c5b5e934484ae3084565abbd3746a98e7f27721/exporter/splunkhecexporter/client.go#L71 The filelog receiver was assuming that `NewNopCreateSettings` returned the same ID, so I re-used the create settings in the test. **Link to tracking Issue:** Blocking open-telemetry/opentelemetry-collector#9637 @dmitryax @Aneurysm9 @codeboten
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
open-telemetry#31659) Follow-up to open-telemetry#31640 I didn't realize the contrib test stopped after the first failure, so there were a few more failures for open-telemetry/opentelemetry-collector#9637. I verified that this passes the contrib-tests check for the core repo locally, so this should be the rest of them. For the splunkhec exporter, the exporter actually uses `ID.String()`: https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/4c5b5e934484ae3084565abbd3746a98e7f27721/exporter/splunkhecexporter/client.go#L71 The filelog receiver was assuming that `NewNopCreateSettings` returned the same ID, so I re-used the create settings in the test. **Link to tracking Issue:** Blocking open-telemetry/opentelemetry-collector#9637 @dmitryax @Aneurysm9 @codeboten
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Follow-up to #31640
I didn't realize the contrib test stopped after the first failure, so there were a few more failures for open-telemetry/opentelemetry-collector#9637.
I verified that this passes the contrib-tests check for the core repo locally, so this should be the rest of them.
For the splunkhec exporter, the exporter actually uses
ID.String():opentelemetry-collector-contrib/exporter/splunkhecexporter/client.go
Line 71 in 4c5b5e9
The filelog receiver was assuming that
NewNopCreateSettingsreturned the same ID, so I re-used the create settings in the test.Link to tracking Issue:
Blocking open-telemetry/opentelemetry-collector#9637
@dmitryax @Aneurysm9 @codeboten