[exporter/loadbalancing] Do not block resolver by the exporter shutdown #31602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
903b520
to
38aca5c
Compare
38aca5c
to
679949f
Compare
songy23
approved these changes
Mar 5, 2024
jpkrohling
reviewed
Mar 6, 2024
| exp := lb.exporters[existing] | ||
| // Shutdown the exporter asynchronously to avoid blocking the resolver | ||
| go func() { | ||
| _ = exp.Shutdown(ctx) |
There was a problem hiding this comment.
I'm OK with this, but isn't it cleaner to use context.WithTimeout wrapping the context? Would Shutdown respect the timeout?
There was a problem hiding this comment.
I'm not sure what's the need for this. With all the locks this shutdown can block consumes which supposed to be handled by other available sub-exporters. If we kill it by timeout, we introduce the same panics back. I think we should mark the sub-exporter as "turned off" and shut it down asynchronously once it handles all the current requests.
|
Merging it as is since I believe it's an important fix based on the feedback #31410. I'm happy to address any other feedback as a follow-up |
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…wn (open-telemetry#31602) This resolves the issues seen in open-telemetry#31410 after merging open-telemetry#31456
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…wn (open-telemetry#31602) This resolves the issues seen in open-telemetry#31410 after merging open-telemetry#31456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issues seen in #31410 after merging #31456