[receiver/k8scluster] add k8s.container.status_last_terminated_reason resource attribute #31505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
Feb 29, 2024
povilasv
force-pushed
the
main-resource-attribute
branch
from
d8404cf
to
1d0d2d0
Compare
|
Thanks for review, updated based on the comment :) |
… resource attribute
povilasv
force-pushed
the
main-resource-attribute
branch
from
1d0d2d0
to
d7d5843
Compare
TylerHelmuth
approved these changes
Mar 12, 2024
| @@ -192,6 +192,11 @@ resource_attributes: | |||
| type: string | |||
| enabled: true | |||
|
|
|||
| k8s.container.status.last_terminated_reason: | |||
There was a problem hiding this comment.
I'd definitely be in favor of submitting a PR to get this attribute added to the semantic conventions. I am growing more and more worried about how many resource attributes/metrics we have in our k8s receivers that arent specified.
There was a problem hiding this comment.
I agree. It shouldn't be a blocker, but we need to submit it make sure it's pushed to the sem conv as well
There was a problem hiding this comment.
Filed an issue for it open-telemetry/semantic-conventions#922, will see what folks will say :)
dmitryax
approved these changes
Mar 12, 2024
DougManton
pushed a commit
to DougManton/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
… resource attribute (open-telemetry#31505) **Description:** Add k8s.container.status.last_terminated_reason resource attribute **Link to tracking Issue:** open-telemetry#31282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add k8s.container.status_last_terminated_reason resource attribute
Link to tracking Issue:
#31282
Testing:
Documentation: