Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googelcloudexporter] Fixed configuration path in README #31404

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

dhrp
Copy link
Contributor

@dhrp dhrp commented Feb 24, 2024

The google cloud exporter README suggests that the configfile is in /etc/otel/config.yaml; but it's not.

(and I pulled my hair out for a while trying to figure out why my config was not working).

Description:

I changed the path used for the config file in the example to reflect the path used / set in the Dockerfile.

Link to tracking Issue:
#31403

Testing:

Documentation:

The google cloud exporter README suggests that the configfile is in /etc/otel/config.yaml; but it's not. 

(and I pulled my hair out for a while trying to figure out why my config was not working).
@dashpole dashpole added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 26, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@dmitryax dmitryax merged commit 368fcdf into open-telemetry:main Mar 7, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 7, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…try#31404)

The google cloud exporter README suggests that the configfile is in
/etc/otel/config.yaml; but it's not.

(and I pulled my hair out for a while trying to figure out why my config
was not working).

**Description:**
I changed the path used for the config file in the example to reflect
the path used / set in the Dockerfile.

**Link to tracking Issue:**
open-telemetry#31403 

---------

Co-authored-by: Ziqi Zhao <[email protected]>
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
…try#31404)

The google cloud exporter README suggests that the configfile is in
/etc/otel/config.yaml; but it's not.

(and I pulled my hair out for a while trying to figure out why my config
was not working).

**Description:**
I changed the path used for the config file in the example to reflect
the path used / set in the Dockerfile.

**Link to tracking Issue:**
open-telemetry#31403 

---------

Co-authored-by: Ziqi Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exporter/googlecloud Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants