Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all github.com/datadog packages #31398

Merged

Conversation

liustanley
Copy link
Contributor

@liustanley liustanley commented Feb 23, 2024

Description:

Updates all datadog dependencies to the psuedo version from the otel/backport branch and addresses the following breaking changes:

Functional changes:

  • Initialize OTLPReceiver.AttributesTranslator in traces pipeline, and set in trace agent configs
  • Metrics client is no longer initalized in createTracesToTracesConnector because there is no initialization of the trace agent in the trace to trace connector
  • InitializeMetricClient can be called multiple times now that the singleton is gone
  • metrics_client.go implements Distribution by calling Histogram for the same implementation
  • metrics_client.go adds placeholders for statsd methods that are not applicable to our collector components

Link to tracking Issue:

Testing:

Documentation:
This PR doesn't have any user facing changes, so no changelog is needed.

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing on behalf of datadog-receiver. I'll defer to @mx-psi for the other ones.

Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need a changelog?

@liustanley
Copy link
Contributor Author

Do you need a changelog?

This PR doesn't have any user facing changes, so no changelog is needed.

@songy23 songy23 added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 26, 2024
@liustanley liustanley changed the title Update all github.com/datadog packages to v0.52.0-rc.2 Update all github.com/datadog packages to v0.52.0-rc.4 Feb 27, 2024
@dmitryax
Copy link
Member

dmitryax commented Feb 27, 2024

Please rebase

@songy23 songy23 added the ready to merge Code review completed; ready to merge by maintainers label Feb 28, 2024
Copy link
Member

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding until next RC

@songy23 songy23 removed the ready to merge Code review completed; ready to merge by maintainers label Feb 28, 2024
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the AttributesTranslator changes

exporter/datadogexporter/factory.go Show resolved Hide resolved
@liustanley liustanley changed the title Update all github.com/datadog packages to v0.52.0-rc.4 Update all github.com/datadog packages Feb 29, 2024
@songy23 songy23 removed the Skip Changelog PRs that do not require a CHANGELOG.md entry label Feb 29, 2024
@codeboten codeboten merged commit 47aa437 into open-telemetry:main Feb 29, 2024
141 of 142 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 29, 2024
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
Updates all datadog dependencies to the psuedo version from the
[otel/backport](https://github.com/DataDog/datadog-agent/tree/otel/backport)
branch and addresses the following breaking changes:
- DataDog/datadog-agent#22729
- DataDog/datadog-agent#22809

Functional changes:
- Initialize `OTLPReceiver.AttributesTranslator` in traces pipeline, and
set in trace agent configs
- Metrics client is no longer initalized in
`createTracesToTracesConnector` because there is no initialization of
the trace agent in the trace to trace connector
- `InitializeMetricClient` can be called multiple times now that the
singleton is gone
- `metrics_client.go` implements `Distribution` by calling `Histogram`
for the same implementation
- `metrics_client.go` adds placeholders for statsd methods that are not
applicable to our collector components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants