Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporter/file] Add group_by configuration #31396

Merged
merged 10 commits into from
Mar 12, 2024

Conversation

adam-kiss-sg
Copy link
Contributor

Description:

Added the option to write telemetry data into multiple files, where the file path is based on a resource attribute.

Link to tracking Issue:

#24654

Testing:

Added tests and benchmark for new functionality.

Documentation:

Updated README.md

Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

exporter/fileexporter/README.md Outdated Show resolved Hide resolved
exporter/fileexporter/README.md Outdated Show resolved Hide resolved
exporter/fileexporter/config.go Outdated Show resolved Hide resolved
exporter/fileexporter/grouping_file_exporter.go Outdated Show resolved Hide resolved
exporter/fileexporter/grouping_file_exporter.go Outdated Show resolved Hide resolved
@djaglowski djaglowski changed the title added group_by to fileexporter [exporter/file] Add group_by configuration Feb 26, 2024
Copy link
Member

@djaglowski djaglowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more nits, and I don't have an answer for the permanent/retryable error question, but otherwise looks good.

exporter/fileexporter/file_exporter_test.go Outdated Show resolved Hide resolved
exporter/fileexporter/file_exporter_test.go Outdated Show resolved Hide resolved
@djaglowski
Copy link
Member

Not sure why the checks aren't running. Mind pushing an empty commit to retrigger them?

@adam-kiss-sg
Copy link
Contributor Author

I did a main merge because there were some conflicts. The two failing checks seems to be due to an upstream issue: tcort/markdown-link-check#297

@djaglowski djaglowski merged commit b9ce2d3 into open-telemetry:main Mar 12, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Mar 12, 2024
DougManton pushed a commit to DougManton/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
**Description:** 

Added the option to write telemetry data into multiple files, where the
file path is based on a resource attribute.

**Link to tracking Issue:** 

open-telemetry#24654

**Testing:** 

Added tests and benchmark for new functionality.

**Documentation:**

Updated README.md
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
**Description:** 

Added the option to write telemetry data into multiple files, where the
file path is based on a resource attribute.

**Link to tracking Issue:** 

open-telemetry#24654

**Testing:** 

Added tests and benchmark for new functionality.

**Documentation:**

Updated README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants