Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP Client to opampextension #31392

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Add HTTP Client to opampextension #31392

merged 7 commits into from
Feb 28, 2024

Conversation

jaronoff97
Copy link
Contributor

Description:

Link to tracking Issue:

Testing:

Documentation:

evan-bradley
evan-bradley reviewed Feb 23, 2024
View reviewed changes
Copy link
Contributor

@evan-bradley evan-bradley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good so far to me.

@jaronoff97
Copy link
Contributor Author

thanks! gonna add some tests and a changelog.

@jaronoff97 jaronoff97 marked this pull request as ready for review February 26, 2024 22:24
@jaronoff97 jaronoff97 requested a review from a team as a code owner February 26, 2024 22:24
evan-bradley
evan-bradley approved these changes Feb 27, 2024
View reviewed changes
extension/opampextension/config_test.go Outdated Show resolved Hide resolved
extension/opampextension/config_test.go Outdated Show resolved Hide resolved
@jaronoff97 jaronoff97 mentioned this pull request Feb 27, 2024
Open
@evan-bradley evan-bradley merged commit bcf64e6 into open-telemetry:main Feb 28, 2024
142 checks passed
@github-actions github-actions bot added this to the next release milestone Feb 28, 2024
@jaronoff97 jaronoff97 deleted the opamp-http branch February 28, 2024 20:07
@jaronoff97 jaronoff97 mentioned this pull request Mar 4, 2024
Closed
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
@jaronoff97 @fatsheep9146 @XinRanZhAWS
Add HTTP Client to opampextension (open-telemetry#31392)
a21e906 
**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->

**Link to tracking Issue:** <Issue number if applicable>

**Testing:** <Describe what testing was performed and which tests were
added.>

**Documentation:** <Describe the documentation added.>

---------

Co-authored-by: Ziqi Zhao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@portertech portertech Awaiting requested review from portertech

@tigrannajaryan tigrannajaryan Awaiting requested review from tigrannajaryan tigrannajaryan is a code owner

Assignees

@fatsheep9146 fatsheep9146

Labels
extension/opamp
Projects
None yet
Milestone
v0.96.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jaronoff97 @evan-bradley @fatsheep9146