Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pkg/ottl] Add isInt function #31307

Merged
merged 2 commits into from
Feb 25, 2024
Merged

[pkg/ottl] Add isInt function #31307

merged 2 commits into from
Feb 25, 2024

Conversation

lkwronski
Copy link
Contributor

Description:
Adds a new IsInt function to facilitate type checking.

Link to tracking Issue: #27894

Testing: Added unit test

Documentation: Updated the func readme.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 17, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lkwronski (54df9ab)
  • ✅ login: TylerHelmuth / name: Tyler Helmuth (d5667fd)

@lkwronski lkwronski force-pushed the lkwronski.issue-27894-is-int-converter branch from 55a891a to 54df9ab Compare February 17, 2024 16:17
@lkwronski
Copy link
Contributor Author

@TylerHelmuth Thanks for the review, is there anything else I should do to merge? I don't have permission to merge.

@TylerHelmuth TylerHelmuth added the ready to merge Code review completed; ready to merge by maintainers label Feb 25, 2024
@evan-bradley evan-bradley merged commit a1a8b7b into open-telemetry:main Feb 25, 2024
147 checks passed
@evan-bradley
Copy link
Contributor

Thanks @lkwronski!

@github-actions github-actions bot added this to the next release milestone Feb 25, 2024
@lkwronski lkwronski mentioned this pull request Feb 26, 2024
Closed
4 tasks
XinRanZhAWS pushed a commit to XinRanZhAWS/opentelemetry-collector-contrib that referenced this pull request Mar 13, 2024
@lkwronski @TylerHelmuth @XinRanZhAWS
[pkg/ottl] Add isInt function (open-telemetry#31307)
4b34861 
**Description:** <Describe what has changed.>
Adds a new `IsInt` function to facilitate type checking. 

**Link to tracking Issue:** open-telemetry#27894 

**Testing:**  Added unit test

**Documentation:**  Updated the func readme.

Co-authored-by: Tyler Helmuth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan-bradley evan-bradley evan-bradley approved these changes

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu bogdandrutu is a code owner

@kentquirk kentquirk Awaiting requested review from kentquirk

Assignees

@dmitryax dmitryax

Labels
pkg/ottl ready to merge Code review completed; ready to merge by maintainers
Projects
None yet
Milestone
v0.96.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lkwronski @evan-bradley @TylerHelmuth @dmitryax