[chore] upgrade actions/upload-artifact and actions/download-artifact to v4
#31236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents failures after updating the upload-artifact action to v4.
codeboten
approved these changes
Feb 13, 2024
XinRanZhAWS
pushed a commit
to XinRanZhAWS/opentelemetry-collector-contrib
that referenced
this pull request
Mar 13, 2024
…act` to `v4` (open-telemetry#31236) The upgrade of `actions/upload-artifact` and `actions/download-artifact` is a breaking change. 1. Both actions need to be upgraded together, as downloading artifacts uploaded with previous version does not work. 2. A breaking change in `upload-artifact` is that you cannot upload to the same artifact name twice. The second point lead to the changes in this pull request. I have modified the names of artifacts to hopefully prevent conflicts. **Link to tracking Issue:** open-telemetry#30102 **Testing:** The changes to the `build-and-test` and `e2e-test` workflows are tested in this PR's checks. The changes to the `load-test` workflow can only be tested after merging to main, I'm afraid, as this is when this workflow is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The upgrade of
actions/upload-artifactandactions/download-artifactis a breaking change.upload-artifactis that you cannot upload to the same artifact name twice.The second point lead to the changes in this pull request. I have modified the names of artifacts to hopefully prevent conflicts.
Link to tracking Issue:
#30102
Testing:
The changes to the
build-and-testande2e-testworkflows are tested in this PR's checks. The changes to theload-testworkflow can only be tested after merging to main, I'm afraid, as this is when this workflow is triggered.Documentation:
No changes needed.