Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] set fixed Go patch version to prevent CI failures #31214

Merged
merged 4 commits into from
Feb 13, 2024
Merged

[chore] set fixed Go patch version to prevent CI failures #31214

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8909f3e
[chore] set fixed Go patch version to prevent CI failures
andrzej-stencel Feb 13, 2024
2a046fd
set toolchain version to 1.21.7
andrzej-stencel Feb 13, 2024
ec2c9a8
fix go-version matching
andrzej-stencel Feb 13, 2024
f49238c
delete "toolchain" line from Cassandra exporter's go.mod
andrzej-stencel Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
run: Install-WindowsFeature -name Web-Server -IncludeManagementTools
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-mod-cache
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/build-and-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -88,7 +88,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -154,7 +154,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand All @@ -177,7 +177,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -237,7 +237,7 @@ jobs:
unittest-matrix:
strategy:
matrix:
go-version: ["~1.22", "~1.21.5"] # 1.20 is interpreted as 1.2 without quotes
go-version: ["1.22.0", "1.21.7"] # 1.20 is interpreted as 1.2 without quotes
group:
- receiver-0
- receiver-1
Expand Down Expand Up @@ -349,7 +349,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -387,7 +387,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand All @@ -413,7 +413,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -482,7 +482,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -615,7 +615,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Mkdir bin and dist
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/changelog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
fetch-depth: 0
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false

# Initializes the CodeQL tools for scanning.
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -128,7 +128,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/load-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -64,7 +64,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prepare-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
path: opentelemetry-collector-contrib
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Prepare release for contrib
working-directory: opentelemetry-collector-contrib
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/prometheus-compliance-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
path: opentelemetry-collector-contrib
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/telemetrygen.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/tidy-dependencies.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
ref: ${{ github.head_ref }}
- uses: actions/setup-go@v5
with:
go-version: ~1.21.5
go-version: "1.21.7"
cache: false
- name: Cache Go
id: go-cache
Expand Down
2 changes: 1 addition & 1 deletion cmd/otelcontribcol/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/cmd/otelcontrib

go 1.21

toolchain go1.21.6
toolchain go1.21.7

require (
github.com/open-telemetry/opentelemetry-collector-contrib/connector/countconnector v0.94.0
Expand Down
2 changes: 1 addition & 1 deletion cmd/oteltestbedcol/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/cmd/oteltestbed

go 1.21

toolchain go1.21.6
toolchain go1.21.7

require (
github.com/open-telemetry/opentelemetry-collector-contrib/exporter/carbonexporter v0.94.0
Expand Down
2 changes: 1 addition & 1 deletion exporter/cassandraexporter/go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module github.com/open-telemetry/opentelemetry-collector-contrib/exporter/cassan

go 1.21

toolchain go1.21.6
toolchain go1.21.7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come this specific exporter needs the toolchain?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea! 😕

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was added via #31109. @codeboten do you know? If it is removed does stuff break?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unclear to me why this exporter needs it. I'd suspect one of its dependencies causes this?

Copy link
Member Author

@andrzej-stencel andrzej-stencel Feb 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me delete the line and see what happens 😄

EDIT: Or even better if all those entries are removed in #31224


require (
github.com/gocql/gocql v1.6.0
Expand Down
Loading